// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "base/ios/ios_util.h"
#import "base/test/ios/wait_util.h"
#import "components/strings/grit/components_strings.h"
#import "ios/chrome/browser/start_surface/ui_bundled/start_surface_features.h"
#import "ios/chrome/browser/ui/content_suggestions/ntp_home_constant.h"
#import "ios/chrome/browser/ui/popup_menu/popup_menu_constants.h"
#import "ios/chrome/browser/ui/toolbar/public/toolbar_constants.h"
#import "ios/chrome/grit/ios_strings.h"
#import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
#import "ios/chrome/test/earl_grey/chrome_earl_grey_ui.h"
#import "ios/chrome/test/earl_grey/chrome_matchers.h"
#import "ios/chrome/test/earl_grey/chrome_test_case.h"
#import "ios/testing/earl_grey/earl_grey_test.h"
#import "net/test/embedded_test_server/default_handlers.h"
#import "net/test/embedded_test_server/embedded_test_server.h"
#import "ui/base/l10n/l10n_util_mac.h"
using chrome_test_util::OmniboxText;
using chrome_test_util::SystemSelectionCallout;
using chrome_test_util::SystemSelectionCalloutCopyButton;
namespace {
// Waits for omnibox suggestion with index `suggestionID` to contain
// `suggestion`.
void WaitForOmniboxSuggestion(NSString* suggestion, int section, int row) {
NSString* accessibilityID =
[NSString stringWithFormat:@"omnibox suggestion %d %d", section, row];
ConditionBlock condition = ^{
NSError* error = nil;
[[EarlGrey
selectElementWithMatcher:grey_allOf(
grey_descendant(
grey_accessibilityLabel(suggestion)),
grey_accessibilityID(accessibilityID),
chrome_test_util::OmniboxPopupRow(),
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_sufficientlyVisible()
error:&error];
return error == nil;
};
GREYAssertTrue(base::test::ios::WaitUntilConditionOrTimeout(
base::test::ios::kWaitForUIElementTimeout, condition),
@"Suggestion not found.");
}
// Wait for an empty omnibox.
void WaitForEmpyOmnibox() {
ConditionBlock condition = ^{
NSError* error = nil;
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText("")
error:&error];
return error == nil;
};
GREYAssert(base::test::ios::WaitUntilConditionOrTimeout(
base::test::ios::kWaitForUIElementTimeout, condition),
@"Waiting for the omnibox to empty.");
}
} // namespace
// Toolbar integration tests for Chrome.
@interface ToolbarTestCase : ChromeTestCase
@end
@implementation ToolbarTestCase
- (void)setUp {
[super setUp];
net::test_server::RegisterDefaultHandlers(self.testServer);
GREYAssertTrue(self.testServer->Start(), @"Server did not start.");
}
#pragma mark Tests
// Verifies that entering a URL in the omnibox navigates to the correct URL and
// displays content.
- (void)testEnterURL {
const GURL URL = self.testServer->GetURL("/destination.html");
[ChromeEarlGrey loadURL:URL];
[[EarlGrey selectElementWithMatcher:OmniboxText(URL.GetContent())]
assertWithMatcher:grey_notNil()];
[ChromeEarlGrey waitForWebStateContainingText:"You've arrived"];
}
// Verifies opening a new tab from the tools menu.
- (void)testNewTabFromMenu {
[ChromeEarlGrey waitForMainTabCount:1];
// Open tab via the UI.
[ChromeEarlGreyUI openToolsMenu];
id<GREYMatcher> newTabButtonMatcher =
grey_accessibilityID(kToolsMenuNewTabId);
[[EarlGrey selectElementWithMatcher:newTabButtonMatcher]
performAction:grey_tap()];
[ChromeEarlGrey waitForMainTabCount:2];
}
// Verifies opening a new incognito tab from the tools menu.
- (void)testNewIncognitoTabFromMenu {
[ChromeEarlGrey waitForIncognitoTabCount:0];
// Open incognito tab.
[ChromeEarlGreyUI openToolsMenu];
id<GREYMatcher> newIncognitoTabButtonMatcher =
grey_accessibilityID(kToolsMenuNewIncognitoTabId);
[[EarlGrey selectElementWithMatcher:newIncognitoTabButtonMatcher]
performAction:grey_tap()];
[ChromeEarlGrey waitForIncognitoTabCount:1];
}
// Tests whether input mode in an omnibox can be canceled via "Cancel" button
// and asserts it doesn't commit the omnibox contents if the input is canceled.
- (void)testToolbarOmniboxCancel {
// Handset only (tablet does not have cancel button).
if ([ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_SKIPPED(@"Test not support on iPad");
}
const GURL URL = self.testServer->GetURL("/echo");
[ChromeEarlGrey loadURL:URL];
[[EarlGrey selectElementWithMatcher:chrome_test_util::DefocusedLocationView()]
performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText(URL.GetContent())];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
performAction:grey_replaceText(@"foo")];
id<GREYMatcher> cancelButton =
grey_accessibilityID(kToolbarCancelOmniboxEditButtonIdentifier);
[[EarlGrey selectElementWithMatcher:cancelButton] performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText(URL.GetContent())];
}
// Tests whether input mode in an omnibox can be canceled via "hide keyboard"
// button and asserts it doesn't commit the omnibox contents if the input is
// canceled.
- (void)testToolbarOmniboxHideKeyboard {
// TODO(crbug.com/41272886): Enable the test for iPad when typing bug is
// fixed.
if ([ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Disabled for iPad due to a simulator bug.");
}
// Tablet only (handset keyboard does not have "hide keyboard" button).
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_SKIPPED(@"Test not support on iPhone");
}
const GURL URL = self.testServer->GetURL("/echo");
[ChromeEarlGrey loadURL:URL];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText(URL.GetContent())];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
performAction:grey_replaceText(@"foo")];
id<GREYMatcher> hideKeyboard = grey_accessibilityLabel(@"Hide keyboard");
[[EarlGrey selectElementWithMatcher:hideKeyboard] performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText(URL.GetContent())];
}
// Tests whether input mode in an omnibox can be canceled via tapping the typing
// shield and asserts it doesn't commit the omnibox contents if the input is
// canceled.
- (void)testToolbarOmniboxTypingShield {
// Tablet only (handset keyboard does not have "hide keyboard" button).
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_SKIPPED(@"There is no typing shield on iPhone, skip.");
}
const GURL URL = self.testServer->GetURL("/echo");
[ChromeEarlGrey loadURL:URL];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText(URL.GetContent())];
[ChromeEarlGreyUI focusOmniboxAndReplaceText:@"foo"];
id<GREYMatcher> typingShield = grey_accessibilityID(@"Typing Shield");
[[EarlGrey selectElementWithMatcher:typingShield] performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText(URL.GetContent())];
}
// Verifies that the keyboard is properly dismissed when a toolbar button
// is pressed (iPad specific).
- (void)testIPadKeyboardDismissOnButtonPress {
// Tablet only (handset keyboard does not have "hide keyboard" button).
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_SKIPPED(@"Test not supported on iPhone");
}
// Load a webpage so that the "Back" button is tappable. Then load a second
// page so that the test can go back once without ending up on the NTP.
// (Subsequent steps in this test require the omnibox to be tappable, but in
// some configurations the NTP only has a fakebox and does not display the
// omnibox.)
[ChromeEarlGrey loadURL:GURL("about:blank")];
[ChromeEarlGrey loadURL:GURL("chrome://version")];
// First test: check that the keyboard is opened when tapping the omnibox,
// and that it is dismissed when the "Back" button is tapped.
[[EarlGrey
selectElementWithMatcher:chrome_test_util::DefocusedLocationView()]
performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Typing Shield")]
assertWithMatcher:grey_notNil()];
[[EarlGrey selectElementWithMatcher:chrome_test_util::BackButton()]
performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Typing Shield")]
assertWithMatcher:grey_notVisible()];
// Second test: check that the keyboard is opened when tapping the omnibox,
// and that it is dismissed when the tools menu button is tapped.
[[EarlGrey
selectElementWithMatcher:chrome_test_util::DefocusedLocationView()]
performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Typing Shield")]
assertWithMatcher:grey_notNil()];
[[EarlGrey selectElementWithMatcher:chrome_test_util::ToolsMenuButton()]
performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Typing Shield")]
assertWithMatcher:grey_notVisible()];
}
// Verifies that copying and pasting a URL includes the hidden protocol prefix.
// TODO(crbug.com/40572353): Enable this test when long press on the steady
// location bar is supported.
- (void)DISABLED_testCopyPasteURL {
// Clear generalPasteboard before and after the test.
[UIPasteboard generalPasteboard].string = @"";
[self setTearDownHandler:^{
[UIPasteboard generalPasteboard].string = @"";
}];
// The URL needs to be long enough so the tap to the omnibox selects it.
const GURL URL = self.testServer->GetURL("http://veryLongURLTestPage");
const GURL secondURL = self.testServer->GetURL("http://pastePage");
[ChromeEarlGrey loadURL:URL];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText(URL.GetContent())];
// Can't access share menu from xctest on iOS 11+, so use the text field
// callout bar instead.
[[EarlGrey
selectElementWithMatcher:chrome_test_util::DefocusedLocationView()]
performAction:grey_tap()];
// Tap twice to get the pre-edit label callout bar copy button.
[[EarlGrey
selectElementWithMatcher:grey_allOf(
grey_ancestor(chrome_test_util::Omnibox()),
grey_kindOfClass([UILabel class]), nil)]
performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:SystemSelectionCalloutCopyButton()]
performAction:grey_tap()];
if ([ChromeEarlGrey isIPadIdiom]) {
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Typing Shield")]
performAction:grey_tap()];
} else {
// Typing shield might be unavailable if there are any suggestions
// displayed in the popup.
[[EarlGrey
selectElementWithMatcher:grey_accessibilityID(
kToolbarCancelOmniboxEditButtonIdentifier)]
performAction:grey_tap()];
}
[ChromeEarlGrey loadURL:secondURL];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
performAction:grey_longPress()];
id<GREYMatcher> pasteBarButton = grey_allOf(
grey_accessibilityLabel(@"Paste"),
grey_not(grey_accessibilityTrait(UIAccessibilityTraitButton)),
grey_not(grey_accessibilityTrait(UIAccessibilityTraitStaticText)), nil);
[[EarlGrey selectElementWithMatcher:pasteBarButton] performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText(URL.spec().c_str())];
}
// Verifies that the clear text button clears any text in the omnibox.
- (void)testOmniboxClearTextButton {
const GURL URL = self.testServer->GetURL("/echo");
[ChromeEarlGrey loadURL:URL];
[[EarlGrey selectElementWithMatcher:chrome_test_util::DefocusedLocationView()]
performAction:grey_tap()];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
performAction:grey_replaceText(@"foo")];
[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
assertWithMatcher:chrome_test_util::OmniboxText("foo")];
id<GREYMatcher> cancelButton = grey_accessibilityLabel(@"Clear Text");
[[EarlGrey selectElementWithMatcher:cancelButton] performAction:grey_tap()];
WaitForEmpyOmnibox();
}
// Types JavaScript into Omnibox and verify that an alert is displayed.
// TODO(crbug.com/362621166): Test is flaky.
- (void)DISABLED_testTypeJavaScriptIntoOmnibox {
[ChromeEarlGrey loadURL:self.testServer->GetURL("/echo")];
[ChromeEarlGreyUI
focusOmniboxAndReplaceText:@"javascript:alert('JS Alert Text');"];
// TODO(crbug.com/40916974): Use simulatePhysicalKeyboardEvent until
// replaceText can properly handle \n.
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"\n" flags:0];
ConditionBlock condition = ^{
NSError* error = nil;
[[EarlGrey
selectElementWithMatcher:grey_accessibilityLabel(@"JS Alert Text")]
assertWithMatcher:grey_sufficientlyVisible()
error:&error];
return error == nil;
};
bool alertVisible = base::test::ios::WaitUntilConditionOrTimeout(
base::test::ios::kWaitForUIElementTimeout, condition);
GREYAssertTrue(alertVisible, @"JavaScript alert didn't appear");
}
// Loads WebUI page, types JavaScript into Omnibox and verifies that alert is
// not displayed. WebUI pages have elevated privileges and should not allow
// script execution.
- (void)testTypeJavaScriptIntoOmniboxWithWebUIPage {
[ChromeEarlGrey loadURL:GURL("chrome://version")];
[ChromeEarlGreyUI focusOmniboxAndReplaceText:@"javascript:alert('Hello');\n"];
[[EarlGrey
selectElementWithMatcher:grey_allOf(grey_accessibilityLabel(@"Hello"),
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_nil()];
}
// Tests typing in the omnibox.
- (void)testToolbarOmniboxTyping {
[[EarlGrey selectElementWithMatcher:chrome_test_util::FakeOmnibox()]
performAction:grey_tap()];
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"a" flags:0];
WaitForOmniboxSuggestion(@"a", 0, 0);
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"b" flags:0];
WaitForOmniboxSuggestion(@"ab", 0, 0);
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"C" flags:UIKeyModifierShift];
WaitForOmniboxSuggestion(@"abC", 0, 0);
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"1" flags:0];
WaitForOmniboxSuggestion(@"abC1", 0, 0);
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"2" flags:0];
WaitForOmniboxSuggestion(@"abC12", 0, 0);
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"@" flags:UIKeyModifierShift];
WaitForOmniboxSuggestion(@"abC12@", 0, 0);
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"{" flags:UIKeyModifierShift];
WaitForOmniboxSuggestion(@"abC12@{", 0, 0);
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"#" flags:UIKeyModifierShift];
WaitForOmniboxSuggestion(@"abC12@{#", 0, 0);
if ([ChromeEarlGrey isIPadIdiom]) {
[ChromeEarlGrey simulatePhysicalKeyboardEvent:@"escape" flags:0];
} else {
id<GREYMatcher> cancelButton =
grey_accessibilityID(kToolbarCancelOmniboxEditButtonIdentifier);
DCHECK(cancelButton);
[[EarlGrey
selectElementWithMatcher:grey_allOf(cancelButton,
grey_sufficientlyVisible(), nil)]
performAction:grey_tap()];
}
WaitForEmpyOmnibox();
}
// Tests typing in the omnibox using the keyboard accessory view.
- (void)testToolbarOmniboxKeyboardAccessoryView {
// Select the omnibox to get the keyboard up.
[[EarlGrey selectElementWithMatcher:chrome_test_util::NewTabPageOmnibox()]
performAction:grey_tap()];
[ChromeEarlGrey
waitForSufficientlyVisibleElementWithMatcher:chrome_test_util::Omnibox()];
// Tap the "/" keyboard accessory button.
id<GREYMatcher> slashButtonMatcher = grey_allOf(
grey_accessibilityLabel(@"/"), grey_kindOfClass([UIButton class]), nil);
[[EarlGrey selectElementWithMatcher:slashButtonMatcher]
performAction:grey_tap()];
// Tap the ".com" keyboard accessory button.
id<GREYMatcher> dotComButtonMatcher =
grey_allOf(grey_accessibilityLabel(@".com"),
grey_kindOfClass([UIButton class]), nil);
[[EarlGrey selectElementWithMatcher:dotComButtonMatcher]
performAction:grey_tap()];
// Verify that the omnibox contains "/.com"
[[EarlGrey selectElementWithMatcher:chrome_test_util::OmniboxText("/.com")]
assertWithMatcher:grey_notNil()];
}
@end
Codebase Browser
chromium