// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
package org.chromium.chrome.browser.incognito;
import static androidx.test.espresso.action.ViewActions.click;
import static androidx.test.espresso.assertion.ViewAssertions.doesNotExist;
import static androidx.test.espresso.assertion.ViewAssertions.matches;
import static androidx.test.espresso.matcher.ViewMatchers.withId;
import static androidx.test.espresso.matcher.ViewMatchers.withText;
import static org.hamcrest.core.AnyOf.anyOf;
import static org.hamcrest.core.Is.is;
import static org.hamcrest.core.StringContains.containsString;
import static org.chromium.ui.test.util.ViewUtils.onViewWaiting;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.espresso.Espresso;
import androidx.test.espresso.NoMatchingViewException;
import androidx.test.filters.LargeTest;
import org.hamcrest.Matchers;
import org.junit.After;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.params.ParameterAnnotations.UseMethodParameter;
import org.chromium.base.test.params.ParameterAnnotations.UseRunnerDelegate;
import org.chromium.base.test.params.ParameterProvider;
import org.chromium.base.test.params.ParameterSet;
import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.Batch;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Criteria;
import org.chromium.base.test.util.CriteriaHelper;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.chrome.browser.customtabs.IncognitoCustomTabActivityTestRule;
import org.chromium.chrome.browser.flags.ChromeSwitches;
import org.chromium.chrome.browser.incognito.IncognitoDataTestUtils.ActivityType;
import org.chromium.chrome.browser.incognito.IncognitoDataTestUtils.TestParams;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabLoadIfNeededCaller;
import org.chromium.chrome.test.ChromeJUnit4RunnerDelegate;
import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
import org.chromium.chrome.test.R;
import org.chromium.chrome.test.util.browser.LocationSettingsTestUtil;
import org.chromium.components.browser_ui.modaldialog.ModalDialogView;
import org.chromium.content_public.browser.test.util.JavaScriptUtils;
import org.chromium.device.geolocation.LocationProviderOverrider;
import org.chromium.device.geolocation.MockLocationProvider;
import org.chromium.net.test.EmbeddedTestServer;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeoutException;
/**
* This test class checks permission leakage between all different pairs of Activity types with a
* constraint that one of the interacting activity must be either Incognito Tab or Incognito CCT.
*/
@RunWith(ParameterizedRunner.class)
@UseRunnerDelegate(ChromeJUnit4RunnerDelegate.class)
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE, ChromeSwitches.DISABLE_ALL_IPH})
@Batch(Batch.PER_CLASS)
public class IncognitoPermissionLeakageTest {
private static final String PERMISSION_HTML_PATH =
"/content/test/data/android/geolocation.html";
private String mPermissionTestPage;
private EmbeddedTestServer mTestServer;
@Rule
public ChromeTabbedActivityTestRule mChromeActivityTestRule =
new ChromeTabbedActivityTestRule();
@Rule
public IncognitoCustomTabActivityTestRule mCustomTabActivityTestRule =
new IncognitoCustomTabActivityTestRule();
@Before
public void setUp() throws TimeoutException {
mTestServer =
EmbeddedTestServer.createAndStartServer(
ApplicationProvider.getApplicationContext());
mPermissionTestPage = mTestServer.getURL(PERMISSION_HTML_PATH);
// Permission related settings.
LocationSettingsTestUtil.setSystemLocationSettingEnabled(true);
LocationProviderOverrider.setLocationProviderImpl(new MockLocationProvider());
ModalDialogView.disableButtonTapProtectionForTesting();
}
@After
public void tearDown() {
ThreadUtils.runOnUiThreadBlocking(
() -> IncognitoDataTestUtils.closeTabs(mChromeActivityTestRule));
}
private void requestLocationPermission(Tab tab) throws TimeoutException, ExecutionException {
// If tab is frozen then getWebContents may return null
ThreadUtils.runOnUiThreadBlocking(() -> tab.loadIfNeeded(TabLoadIfNeededCaller.OTHER));
CriteriaHelper.pollUiThread(
() -> Criteria.checkThat(tab.getWebContents(), Matchers.notNullValue()));
JavaScriptUtils.executeJavaScriptAndWaitForResult(
tab.getWebContents(), "initiate_getCurrentPosition()");
}
private void assertDialogIsShown() throws NoMatchingViewException {
onViewWaiting(withId(R.id.text)).check(matches(withText(containsString("location"))));
}
private void assertDialogIsNotShown() throws NoMatchingViewException {
Espresso.onView(withId(R.id.text)).check(doesNotExist());
}
private void grantPermission() {
Espresso.onView(withText(anyOf(is("Allow"), is("Allow this time")))).perform(click());
}
private void blockPermission() {
Espresso.onView(withText(anyOf(containsString("Block"), containsString("Don't allow"))))
.perform(click());
}
/**
* A class providing test parameters encapsulating different Activity type pairs spliced on
* Regular and Incognito mode.
*/
public static class RegularAndIncognito implements ParameterProvider {
@Override
public List<ParameterSet> getParameters() {
List<ParameterSet> result = new ArrayList<>();
result.addAll(new TestParams.IncognitoToRegular().getParameters());
result.addAll(new TestParams.RegularToIncognito().getParameters());
return result;
}
}
@Test
@LargeTest
@UseMethodParameter(RegularAndIncognito.class)
@DisabledTest(message = "https://crbug.com/1103488")
public void testAllowPermissionDoNotLeakBetweenRegularAndIncognito(
String activityType1, String activityType2) throws Exception {
ActivityType activity1 = ActivityType.valueOf(activityType1);
ActivityType activity2 = ActivityType.valueOf(activityType2);
Tab tab1 =
activity1.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission in activity1's tab and accept it.
requestLocationPermission(tab1);
assertDialogIsShown();
grantPermission();
Tab tab2 =
activity2.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission in activity2's tab.
requestLocationPermission(tab2);
// Permission is asked again.
assertDialogIsShown();
}
@Test
@LargeTest
@UseMethodParameter(TestParams.IncognitoToIncognito.class)
public void testAllowPermissionDoNotLeakFromIncognitoToIncognito(
String incognitoActivityType1, String incognitoActivityType2) throws Exception {
// At least one of the incognitoActivity is an incognito CCT.
ActivityType incognitoActivity1 = ActivityType.valueOf(incognitoActivityType1);
ActivityType incognitoActivity2 = ActivityType.valueOf(incognitoActivityType2);
Tab tab1 =
incognitoActivity1.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission in incognitoActivity1's tab and accept it.
requestLocationPermission(tab1);
assertDialogIsShown();
grantPermission();
Tab tab2 =
incognitoActivity2.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission in incognitoActivity2's tab.
requestLocationPermission(tab2);
// Incognito CCTs should not inherit permissions from other sessions.
// If permission is asked again, we can infer that the previous permission wasn't inherited.
assertDialogIsShown();
}
@Test
@LargeTest
@UseMethodParameter(TestParams.IncognitoToIncognito.class)
public void testBlockPermissionDoNotLeakFromIncognitoToIncognito(
String incognitoActivityType1, String incognitoActivityType2) throws Exception {
ActivityType incognitoActivity1 = ActivityType.valueOf(incognitoActivityType1);
ActivityType incognitoActivity2 = ActivityType.valueOf(incognitoActivityType2);
Tab tab1 =
incognitoActivity1.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission in incognitoActivity1's tab and block it.
requestLocationPermission(tab1);
assertDialogIsShown();
blockPermission();
Tab tab2 =
incognitoActivity2.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission now in incognitoActivity2's tab.
requestLocationPermission(tab2);
// Incognito CCTs should not inherit permissions from other sessions.
// If permission is asked again, we can infer that the previous permission wasn't inherited.
assertDialogIsShown();
}
@Test
@LargeTest
@UseMethodParameter(TestParams.RegularToIncognito.class)
@DisabledTest(message = "crbug.com/1489541")
public void testBlockPermissionLeakFromRegularToIncognito(
String regularActivityType, String incognitoActivityType) throws Exception {
ActivityType regularActivity = ActivityType.valueOf(regularActivityType);
ActivityType incognitoActivity = ActivityType.valueOf(incognitoActivityType);
Tab tab1 =
regularActivity.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission in regularActivity's tab and block it.
requestLocationPermission(tab1);
assertDialogIsShown();
blockPermission();
Tab tab2 =
incognitoActivity.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission in incognitoActivity's tab.
requestLocationPermission(tab2);
// Dialog is not shown again to the new tab as the permission was blocked for this site in
// regular.
assertDialogIsNotShown();
}
@Test
@LargeTest
@UseMethodParameter(TestParams.IncognitoToRegular.class)
@DisabledTest(message = "https://crbug.com/1103488")
public void testBlockPermissionDoNotLeakFromIncognitoToRegular(
String incognitoActivityType, String regularActivityType) throws Exception {
ActivityType incognitoActivity = ActivityType.valueOf(incognitoActivityType);
ActivityType regularActivity = ActivityType.valueOf(regularActivityType);
Tab tab1 =
incognitoActivity.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission in incognitoActivity's tab and accept it.
requestLocationPermission(tab1);
assertDialogIsShown();
blockPermission();
Tab tab2 =
regularActivity.launchUrl(
mChromeActivityTestRule, mCustomTabActivityTestRule, mPermissionTestPage);
// Request permission in regularActivity's tab.
requestLocationPermission(tab2);
// Dialog is shown again in tab2 and the permission is therefore not leaked.
assertDialogIsShown();
}
}
Codebase Browser
chromium