/* Copyright (c) 2015-2024 The Khronos Group Inc. * Copyright (c) 2015-2024 Valve Corporation * Copyright (c) 2015-2024 LunarG, Inc. * Copyright (C) 2015-2024 Google Inc. * Modifications Copyright (C) 2020 Advanced Micro Devices, Inc. All rights reserved. * Modifications Copyright (C) 2022 RasterGrid Kft. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ #include "cc_state_tracker.h" #include "core_validation.h" core::CommandBuffer::CommandBuffer(CoreChecks& core, VkCommandBuffer handle, const VkCommandBufferAllocateInfo* allocate_info, const vvl::CommandPool* pool) : … { … } // Much of the data stored in vvl::CommandBuffer is only used by core validation, and is // set up by Record calls in class CoreChecks. Because both the state tracker and // core methods must lock vvl::CommandBuffer, it is possible for a Validate call to // 'interrupt' a Record call and get only the state updated by whichever code // locked and unlocked the CB first. This can only happen if the application // is violating section 3.6 'Threading Behavior' of the specification, which // requires that command buffers be externally synchronized. Still, we'd prefer // not to crash if that happens. In most cases the core Record method is operating // on separate data members from the state tracker. But in the case of vkCmdWaitEvents*, // both methods operate on the same state in ways that could very easily crash if // not done within the same lock guard. Overriding RecordWaitEvents() allows // this to all happen completely while the state tracker is holding the lock. // Eventually we'll probably want to move all of the core state into this derived // class. void core::CommandBuffer::RecordWaitEvents(vvl::Func command, uint32_t eventCount, const VkEvent* pEvents, VkPipelineStageFlags2KHR srcStageMask) { … } std::shared_ptr<vvl::CommandBuffer> CoreChecks::CreateCmdBufferState(VkCommandBuffer handle, const VkCommandBufferAllocateInfo* allocate_info, const vvl::CommandPool* pool) { … }