// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/autofill/android/save_update_address_profile_prompt_controller.h"
#include <jni.h>
#include <memory>
#include <string>
#include "base/android/jni_android.h"
#include "base/android/scoped_java_ref.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/mock_callback.h"
#include "base/uuid.h"
#include "chrome/browser/autofill/android/personal_data_manager_android.h"
#include "chrome/browser/signin/identity_manager_factory.h"
#include "chrome/browser/sync/sync_service_factory.h"
#include "chrome/browser/ui/autofill/chrome_autofill_client.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "components/autofill/core/browser/autofill_test_utils.h"
#include "components/autofill/core/browser/data_model/autofill_profile_test_api.h"
#include "components/autofill/core/browser/test_personal_data_manager.h"
#include "components/signin/public/base/consent_level.h"
#include "components/signin/public/identity_manager/identity_test_environment.h"
#include "components/strings/grit/components_strings.h"
#include "components/sync/test/test_sync_service.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
namespace autofill {
namespace {
using profile_ref = base::optional_ref<const AutofillProfile>;
using ::testing::AllOf;
using ::testing::Property;
std::unique_ptr<KeyedService> CreateTestSyncService(
content::BrowserContext* context) {
return std::make_unique<syncer::TestSyncService>();
}
} // namespace
class MockSaveUpdateAddressProfilePromptView
: public SaveUpdateAddressProfilePromptView {
public:
MOCK_METHOD(bool,
Show,
(SaveUpdateAddressProfilePromptController * controller,
const AutofillProfile& autofill_profile,
bool is_update,
bool is_migration_to_account),
(override));
};
class SaveUpdateAddressProfilePromptControllerTest
: public ChromeRenderViewHostTestHarness {
public:
static constexpr char const* kUserEmail = "[email protected]";
void SetUp() override {
ChromeRenderViewHostTestHarness::SetUp();
test_personal_data_.SetSyncServiceForTest(&sync_service_);
profile_ = test::GetFullProfile();
original_profile_ = test::GetFullProfile();
original_profile_.SetInfo(NAME_FULL, u"John Doe", GetLocale());
original_profile_.SetInfo(PHONE_HOME_WHOLE_NUMBER, u"", GetLocale());
}
TestingProfile::TestingFactories GetTestingFactories() const override {
return {TestingProfile::TestingFactory{
SyncServiceFactory::GetInstance(),
base::BindRepeating(&CreateTestSyncService)}};
}
void TearDown() override { ChromeRenderViewHostTestHarness::TearDown(); }
// Profile with verified data as it is returned from Java.
AutofillProfile GetFullProfileWithVerifiedData() {
AutofillProfile profile(AddressCountryCode("US"));
profile.SetRawInfoWithVerificationStatus(NAME_FULL, u"Mona J. Liza",
VerificationStatus::kUserVerified);
test::SetProfileInfo(&profile, "", "", "", "[email protected]",
"Company Inc.", "33 Narrow Street", "Apt 42",
"Playa Vista", "LA", "12345", "US", "13105551234",
/*finalize=*/true, VerificationStatus::kUserVerified);
return profile;
}
protected:
void SigninUser();
void SetUpController(bool is_update, bool is_migration_to_account);
std::string GetLocale() { return "en-US"; }
signin::IdentityTestEnvironment identity_test_env_;
syncer::TestSyncService sync_service_;
autofill::TestPersonalDataManager test_personal_data_;
raw_ptr<MockSaveUpdateAddressProfilePromptView> prompt_view_ = nullptr;
AutofillProfile profile_{
autofill::i18n_model_definition::kLegacyHierarchyCountryCode};
AutofillProfile original_profile_{
autofill::i18n_model_definition::kLegacyHierarchyCountryCode};
bool is_update_;
base::MockCallback<AutofillClient::AddressProfileSavePromptCallback>
decision_callback_;
base::MockCallback<base::OnceCallback<void()>> dismissal_callback_;
std::unique_ptr<SaveUpdateAddressProfilePromptController> controller_;
raw_ptr<JNIEnv> env_ = base::android::AttachCurrentThread();
base::android::JavaParamRef<jobject> mock_caller_{nullptr};
};
void SaveUpdateAddressProfilePromptControllerTest::SigninUser() {
identity_test_env_.MakePrimaryAccountAvailable(kUserEmail,
signin::ConsentLevel::kSignin);
}
void SaveUpdateAddressProfilePromptControllerTest::SetUpController(
bool is_update,
bool is_migration_to_account) {
is_update_ = is_update;
auto prompt_view = std::make_unique<MockSaveUpdateAddressProfilePromptView>();
prompt_view_ = prompt_view.get();
controller_ = std::make_unique<SaveUpdateAddressProfilePromptController>(
std::move(prompt_view), &test_personal_data_, profile_,
is_update ? &original_profile_ : nullptr, is_migration_to_account,
decision_callback_.Get(), dismissal_callback_.Get());
ON_CALL(*prompt_view_,
Show(controller_.get(), profile_, is_update, is_migration_to_account))
.WillByDefault(testing::Return(true));
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldShowViewOnDisplayPromptWhenSave) {
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/false);
EXPECT_CALL(*prompt_view_,
Show(controller_.get(), profile_, /*is_update=*/false,
/*is_migration_to_account=*/false));
controller_->DisplayPrompt();
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldShowViewOnDisplayPromptWhenMigrate) {
SigninUser();
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/true);
EXPECT_CALL(*prompt_view_,
Show(controller_.get(), profile_, /*is_update=*/false,
/*is_migration_to_account=*/true));
controller_->DisplayPrompt();
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldShowViewOnDisplayPromptWhenUpdate) {
SetUpController(/*is_update=*/true, /*is_migration_to_account=*/false);
EXPECT_CALL(*prompt_view_,
Show(controller_.get(), profile_, /*is_update=*/true,
/*is_migration_to_account=*/false));
controller_->DisplayPrompt();
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldInvokeDismissalCallbackWhenShowReturnsFalse) {
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/false);
EXPECT_CALL(*prompt_view_,
Show(controller_.get(), profile_, /*is_update=*/false,
/*is_migration_to_account=*/false))
.WillOnce(testing::Return(false));
EXPECT_CALL(dismissal_callback_, Run());
controller_->DisplayPrompt();
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldInvokeSaveCallbackWhenUserAccepts) {
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/false);
controller_->DisplayPrompt();
EXPECT_CALL(decision_callback_,
Run(AutofillClient::AddressPromptUserDecision::kAccepted,
Property(&profile_ref::has_value, false)));
controller_->OnUserAccepted(env_, mock_caller_);
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldInvokeSaveCallbackWhenUserDeclines) {
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/false);
controller_->DisplayPrompt();
EXPECT_CALL(decision_callback_,
Run(AutofillClient::AddressPromptUserDecision::kDeclined,
Property(&profile_ref::has_value, false)));
controller_->OnUserDeclined(env_, mock_caller_);
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldInvokeSaveCallbackWhenUserDeclinesMigration) {
SigninUser();
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/true);
controller_->DisplayPrompt();
EXPECT_CALL(decision_callback_,
Run(AutofillClient::AddressPromptUserDecision::kNever,
Property(&profile_ref::has_value, false)));
controller_->OnUserDeclined(env_, mock_caller_);
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldInvokeSaveCallbackWhenUserEditsProfile) {
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/false);
controller_->DisplayPrompt();
AutofillProfile edited_profile = GetFullProfileWithVerifiedData();
EXPECT_CALL(decision_callback_,
Run(AutofillClient::AddressPromptUserDecision::kEditAccepted,
AllOf(Property(&profile_ref::has_value, true),
Property(&profile_ref::value, edited_profile))));
base::android::ScopedJavaLocalRef<jobject> edited_profile_java =
edited_profile.CreateJavaObject(
g_browser_process->GetApplicationLocale());
controller_->OnUserEdited(
env_, mock_caller_,
base::android::JavaParamRef<jobject>(env_, edited_profile_java.obj()));
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldInvokeDismissalCallbackWhenPromptIsDismissed) {
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/false);
controller_->DisplayPrompt();
EXPECT_CALL(dismissal_callback_, Run());
controller_->OnPromptDismissed(env_, mock_caller_);
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ShouldInvokeSaveCallbackWhenControllerDiesWithoutInteraction) {
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/false);
controller_->DisplayPrompt();
EXPECT_CALL(decision_callback_,
Run(AutofillClient::AddressPromptUserDecision::kIgnored,
Property(&profile_ref::has_value, false)));
controller_.reset();
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ReturnsCorrectStringsToDisplayWhenSaveLocalOrSyncAddress) {
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/false);
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_AUTOFILL_SAVE_ADDRESS_PROMPT_TITLE),
controller_->GetTitle());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_SAVE_ADDRESS_PROMPT_OK_BUTTON_LABEL),
controller_->GetPositiveButtonText());
EXPECT_EQ(
u"John H. Doe\nUnderworld\n666 Erebus St.\nApt 8\nElysium, CA "
u"91111\nUnited States",
controller_->GetAddress());
EXPECT_EQ(u"[email protected]", controller_->GetEmail());
EXPECT_EQ(u"16502111111", controller_->GetPhoneNumber());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_ANDROID_AUTOFILL_SAVE_ADDRESS_PROMPT_CANCEL_BUTTON_LABEL),
controller_->GetNegativeButtonText());
EXPECT_EQ(
u"", controller_->GetSourceNotice(identity_test_env_.identity_manager()));
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ReturnsCorrectStringsToDisplayWhenMigrateLocalAddress) {
sync_service_.GetUserSettings()->SetSelectedTypes(
/*sync_everything=*/false,
/*types=*/{syncer::UserSelectableType::kPasswords});
SigninUser();
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/true);
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_ACCOUNT_MIGRATE_ADDRESS_PROMPT_TITLE),
controller_->GetTitle());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_SAVE_ADDRESS_PROMPT_MIGRATION_OK_BUTTON_LABEL),
controller_->GetPositiveButtonText());
EXPECT_EQ(u"John H. Doe\n666 Erebus St.", controller_->GetAddress());
EXPECT_EQ(u"[email protected]", controller_->GetEmail());
EXPECT_EQ(u"16502111111", controller_->GetPhoneNumber());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_MIGRATE_ADDRESS_PROMPT_CANCEL_BUTTON_LABEL),
controller_->GetNegativeButtonText());
EXPECT_EQ(
l10n_util::GetStringFUTF16(
IDS_AUTOFILL_LOCAL_PROFILE_MIGRATION_PROMPT_NOTICE,
base::ASCIIToUTF16(kUserEmail)),
controller_->GetSourceNotice(identity_test_env_.identity_manager()));
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ReturnsCorrectStringsToDisplayWhenMigrateSyncAddress) {
sync_service_.GetUserSettings()->SetSelectedTypes(
/*sync_everything=*/false,
/*types=*/{syncer::UserSelectableType::kAutofill});
SigninUser();
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/true);
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_ACCOUNT_MIGRATE_ADDRESS_PROMPT_TITLE),
controller_->GetTitle());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_SAVE_ADDRESS_PROMPT_MIGRATION_OK_BUTTON_LABEL),
controller_->GetPositiveButtonText());
EXPECT_EQ(u"John H. Doe\n666 Erebus St.", controller_->GetAddress());
EXPECT_EQ(u"[email protected]", controller_->GetEmail());
EXPECT_EQ(u"16502111111", controller_->GetPhoneNumber());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_MIGRATE_ADDRESS_PROMPT_CANCEL_BUTTON_LABEL),
controller_->GetNegativeButtonText());
EXPECT_EQ(
l10n_util::GetStringFUTF16(
IDS_AUTOFILL_SYNCABLE_PROFILE_MIGRATION_PROMPT_NOTICE,
base::ASCIIToUTF16(kUserEmail)),
controller_->GetSourceNotice(identity_test_env_.identity_manager()));
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ReturnsCorrectStringsToDisplayWhenSaveAccountAddress) {
SigninUser();
test_api(profile_).set_record_type(AutofillProfile::RecordType::kAccount);
SetUpController(/*is_update=*/false, /*is_migration_to_account=*/false);
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_AUTOFILL_SAVE_ADDRESS_PROMPT_TITLE),
controller_->GetTitle());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_SAVE_ADDRESS_PROMPT_OK_BUTTON_LABEL),
controller_->GetPositiveButtonText());
EXPECT_EQ(
u"John H. Doe\nUnderworld\n666 Erebus St.\nApt 8\nElysium, CA "
u"91111\nUnited States",
controller_->GetAddress());
EXPECT_EQ(u"[email protected]", controller_->GetEmail());
EXPECT_EQ(u"16502111111", controller_->GetPhoneNumber());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_ANDROID_AUTOFILL_SAVE_ADDRESS_PROMPT_CANCEL_BUTTON_LABEL),
controller_->GetNegativeButtonText());
EXPECT_EQ(
l10n_util::GetStringFUTF16(
IDS_AUTOFILL_ADDRESS_WILL_BE_SAVED_IN_ACCOUNT_SOURCE_NOTICE,
base::ASCIIToUTF16(kUserEmail)),
controller_->GetSourceNotice(identity_test_env_.identity_manager()));
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ReturnsCorrectStringsToDisplayWhenUpdateLocalOrSyncAddress) {
SetUpController(/*is_update=*/true, /*is_migration_to_account=*/false);
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_AUTOFILL_UPDATE_ADDRESS_PROMPT_TITLE),
controller_->GetTitle());
EXPECT_EQ(u"John Doe, 666 Erebus St.", controller_->GetSubtitle());
std::pair<std::u16string, std::u16string> differences =
controller_->GetDiffFromOldToNewProfile();
EXPECT_EQ(u"John Doe", differences.first);
EXPECT_EQ(u"John H. Doe\n16502111111", differences.second);
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_UPDATE_ADDRESS_PROMPT_OK_BUTTON_LABEL),
controller_->GetPositiveButtonText());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_ANDROID_AUTOFILL_SAVE_ADDRESS_PROMPT_CANCEL_BUTTON_LABEL),
controller_->GetNegativeButtonText());
EXPECT_EQ(
u"", controller_->GetSourceNotice(identity_test_env_.identity_manager()));
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ReturnsCorrectStringsToDisplayWhenUpdateAccountAddress) {
SigninUser();
test_api(profile_).set_record_type(AutofillProfile::RecordType::kAccount);
SetUpController(/*is_update=*/true, /*is_migration_to_account=*/false);
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_AUTOFILL_UPDATE_ADDRESS_PROMPT_TITLE),
controller_->GetTitle());
EXPECT_EQ(u"John Doe, 666 Erebus St.", controller_->GetSubtitle());
std::pair<std::u16string, std::u16string> differences =
controller_->GetDiffFromOldToNewProfile();
EXPECT_EQ(u"John Doe", differences.first);
EXPECT_EQ(u"John H. Doe\n16502111111", differences.second);
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_AUTOFILL_UPDATE_ADDRESS_PROMPT_OK_BUTTON_LABEL),
controller_->GetPositiveButtonText());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_ANDROID_AUTOFILL_SAVE_ADDRESS_PROMPT_CANCEL_BUTTON_LABEL),
controller_->GetNegativeButtonText());
EXPECT_EQ(
l10n_util::GetStringFUTF16(
IDS_AUTOFILL_ADDRESS_ALREADY_SAVED_IN_ACCOUNT_SOURCE_NOTICE,
base::ASCIIToUTF16(kUserEmail)),
controller_->GetSourceNotice(identity_test_env_.identity_manager()));
}
TEST_F(SaveUpdateAddressProfilePromptControllerTest,
ReturnsCorrectStringsToDisplayWhenUpdateWithAddressChanged) {
original_profile_ = test::GetFullProfile();
original_profile_.SetInfo(ADDRESS_HOME_ZIP, u"", GetLocale());
original_profile_.SetInfo(PHONE_HOME_WHOLE_NUMBER, u"", GetLocale());
SetUpController(/*is_update=*/true, /*is_migration_to_account=*/false);
// Subtitle should contain the full name only.
EXPECT_EQ(u"John H. Doe", controller_->GetSubtitle());
std::pair<std::u16string, std::u16string> differences =
controller_->GetDiffFromOldToNewProfile();
// Differences should contain envelope style address.
EXPECT_EQ(u"Underworld\n666 Erebus St.\nApt 8\nElysium, CA \nUnited States",
differences.first);
// There should be an extra newline between address and contacts data.
EXPECT_EQ(
u"Underworld\n666 Erebus St.\nApt 8\nElysium, CA 91111\nUnited "
u"States\n\n16502111111",
differences.second);
EXPECT_EQ(
u"", controller_->GetSourceNotice(identity_test_env_.identity_manager()));
}
} // namespace autofill
Codebase Browser
chromium